Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - Print out config path when saving #1673

Merged
merged 3 commits into from
Sep 19, 2024
Merged

CLI - Print out config path when saving #1673

merged 3 commits into from
Sep 19, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Sep 4, 2024

Description of Changes

Fixes #1672.

API and ABI breaking changes

Nope!

Expected complexity level and risk

1

Testing

$ cargo run -- call foo bar
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s
     Running `target/debug/spacetime call foo bar`
Saving config to /home/lead/.spacetime/config.toml..
Error: The dns resolution of `foo` failed.

@bfops bfops marked this pull request as ready for review September 4, 2024 21:26
@bfops bfops enabled auto-merge September 4, 2024 21:43
@bfops bfops requested review from gefjon and removed request for gefjon September 5, 2024 17:37
@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Sep 9, 2024
mamcx
mamcx approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit cb3ca4d Sep 19, 2024
10 checks passed
bfops added a commit that referenced this pull request Oct 2, 2024
@bfops
Revert "CLI - Print out config path when saving (#1673)"
c23a7be 
This reverts commit cb3ca4d.
bfops added a commit that referenced this pull request Oct 2, 2024
@bfops
[release/v0.12.0-beta]: Revert "CLI - Print out config path when savi…
683b5f6 
…ng (#1673)"

This reverts commit cb3ca4d.
bfops added a commit that referenced this pull request Oct 2, 2024
@bfops
[release/v0.12.0-beta]: Revert "CLI - Print out config path when savi…
253f045 
…ng (#1673)"

This reverts commit cb3ca4d.
bfops added a commit that referenced this pull request Oct 3, 2024
@bfops
[release/v0.12.0-beta]: Revert "CLI - Print out config path when savi…
aff09eb 
…ng (#1673)"

This reverts commit cb3ca4d.
@bfops bfops deleted the bfops/print-config-path branch October 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

Assignees
No one assigned
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI - Print out the path of the config file being updated
2 participants
@bfops @mamcx