Switch Rust codegen to use new ModuleDef #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/rust-codegen-typespace_for_generate
branch
from
d8d1485
to
dfe601f
Compare
coolreader18
force-pushed
the
noa/rust-codegen-typespace_for_generate
branch
3 times, most recently
from
0da5569
to
2dffb7c
Compare
coolreader18
force-pushed
the
noa/rust-codegen-typespace_for_generate
branch
from
2dffb7c
to
f6d2e77
Compare
coolreader18
force-pushed
the
noa/rust-codegen-typespace_for_generate
branch
from
f6d2e77
to
7a3fe5d
Compare
kazimuth
reviewed
Sep 17, 2024
kazimuth
approved these changes
Sep 17, 2024
|
|
||
| Ok(files) | ||
| pub fn generate(module: RawModuleDef, lang: Language, namespace: &str) -> anyhow::Result<Vec<(String, String)>> { | ||
| let module = match module { |
There was a problem hiding this comment.
Also this whole function looks good, this was exactly the structure I thought would make sense here while we port
| } | ||
| write_type(ctx, out, &elem.algebraic_type) | ||
| })?; | ||
| AlgebraicTypeUse::Unit => write!(out, "()")?, |
| extract_descriptions(module.path()).expect("failed to extract module descriptions"); | ||
| let RawModuleDef::V8BackCompat(raw_module_def) = raw_module_def else { | ||
| panic!("no more v8") | ||
| }; |
There was a problem hiding this comment.
So both C# and rust are patched to produce v9 now?
There was a problem hiding this comment.
No, not yet - the panic!() will happen when v8 is no longer being produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Based on #1661. The way I did this also allows for incremental porting of the typescript & csharp codegens - obviously it should happen soon, but this is nice cause it allows avoiding conflicts (unless Ingvar's already started working on the csharp one).
Expected complexity level and risk
2
Testing
Snapshot tests all pass.