Add spacetimedb_primitives::col_list::ColSet #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested changes
Sep 10, 2024
Typo Apply suggestions from code review ty mazdak Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: james gilles <jameshgilles@gmail.com>
kazimuth
force-pushed
the
jgilles/col_set
branch
from
5991b41
to
b7c94f1
Compare
|
@Centril comments addressed :) |
Centril
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I want to use this for constraints in
ModuleDef.API and ABI breaking changes
None
Expected complexity level and risk
1, this adds unsafe code but it's fairly trivial.
Testing
Added a proptest.