snapshot: pub access to snapshot file + object repo #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I did not pay much attention to API, I may do so once I get to the receiving end (which will have to do the validation work). |
In order to serve a snapshot over the network, memory and CPU (validation) requirements for the server should be minimized. Expose methods to allow implementing different strategies than materializing an entire `ReconstructedSnapshot`.
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io> Signed-off-by: Kim Altintop <kim@eagain.io>
kim
force-pushed
the
kim/snapshot/pub-file-and-object-repo
branch
from
38cfbcd
to
9752fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to serve a snapshot over the network, memory and CPU (validation) requirements for the server should be minimized.
Expose methods to allow implementing different strategies than materializing an entire
ReconstructedSnapshot.Expected complexity level and risk
0