Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes showing server errors on cli sql calls #1720

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fixes showing server errors on cli sql calls #1720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/cli/src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ pub async fn error_for_status(response: Response) -> Result<Response, CliError>
if let Some(kind) = status
.is_client_error()
.then_some(RequestSource::Client)
.or_else(|| status.is_client_error().then_some(RequestSource::Server))
// Anything that is not a success is an error for the client, even a redirect that is not followed.
.or_else(|| (!status.is_success()).then_some(RequestSource::Server))
{
let msg = response.text().await?;
return Err(CliError::Request { kind, msg, status });
Expand Down
Loading