perf: Use type ids for type checking #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
reviewed
Sep 20, 2024
|
|
||
| /// Add a type to the context and return a [TyId] for it. | ||
| /// The [TyId] is not guaranteed to be unique to the type. | ||
| /// However for primitive types it will be. |
There was a problem hiding this comment.
There is any problem with making it unique?
There was a problem hiding this comment.
No problem, it just requires more memory and it becomes a little more expensive to generate type ids. But the benefit is that we only need type ids to test for equality.
crates/planner/src/logical/ty.rs
Outdated
| (BinOp::And | BinOp::Or, Type::Alg(AlgebraicType::Bool)) => true, | ||
| // Comparison operators take integers or floats | ||
| (BinOp::Lt | BinOp::Gt | BinOp::Lte | BinOp::Gte, Type::Alg(t)) => t.is_integer() || t.is_float(), | ||
| // Equality supports numerics, strings, and bytes |
There was a problem hiding this comment.
Mainly to avoid inconsistencies with other type systems. In the case of Rust, sums and products correspond to enum and struct types. Those types could have custom Eq and Ord implementations and as of right now, we don't have a way of representing that in SpacetimeDB.
joshua-spacetime
force-pushed
the
joshua/perf/type-check
branch
from
bb87e04
to
7a35760
Compare
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/perf/type-check
branch
from
7a35760
to
206c618
Compare
A `RelExpr` now holds type ids instead of types. This reduces the size of `RelExpr`. It avoids copying and cloning types during type checking. Comparisons are also cheaper for primitive types.
joshua-spacetime
force-pushed
the
joshua/perf/type-check
branch
from
206c618
to
6233a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
RelExprnow holds type ids instead of types.This reduces the size of
RelExpr.It avoids copying and cloning types during type checking. Comparisons are also cheaper for primitive types.