feat: Type check DML #1727
Merged
feat: Type check DML #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
reviewed
Sep 23, 2024
mamcx
reviewed
Sep 23, 2024
| pub values: usize, | ||
| pub fields: usize, | ||
| } | ||
|
|
There was a problem hiding this comment.
Will be nice to know which fields/values failed here.
There was a problem hiding this comment.
I added a TODO to that effect
mamcx
reviewed
Sep 23, 2024
| @@ -89,6 +89,14 @@ pub enum Unsupported { | |||
| UnqualifiedProjectExpr, | |||
| } | |||
|
|
|||
| #[derive(Error, Debug)] | |||
| #[error("Inserting a row with {values} values into {table} which has {fields} fields")] | |||
| pub struct InsertError { | |||
There was a problem hiding this comment.
Other errors use the convention of enclosing the error fields with "`" as Inserting a row with `{values}`...
There was a problem hiding this comment.
👍 I updated the all the other error messages as well.
mamcx
reviewed
Sep 23, 2024
joshua-spacetime
force-pushed
the
joshua/perf/type-check
branch
3 times, most recently
from
206c618
to
6233a33
Compare
joshua-spacetime
force-pushed
the
joshua/feat/type-check-dml
branch
2 times, most recently
from
6af3279
to
9c03e47
Compare
mamcx
approved these changes
Sep 24, 2024
joshua-spacetime
force-pushed
the
joshua/feat/type-check-dml
branch
from
1de71d5
to
e956f98
Compare
joshua-spacetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added type checking and name resolution for SQL DML statements
Expected complexity level and risk
2
Testing