Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker Build (dont merge) #175

Closed
wants to merge 4 commits into from
Closed

Fix Docker Build (dont merge) #175

wants to merge 4 commits into from

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Aug 11, 2023 •
edited
Loading

Description of Changes

  • We didn't really change anything and the docker builds stopped working. It seems like binstall was updated and now requires that QUIC be installed on the host system. This PR just installs rustup normally and then installs all of our utils from that.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

@jdetter jdetter changed the title jdetter/fix docker multiplatform Fix Docker Build Aug 11, 2023
@jdetter jdetter requested a review from drogus August 11, 2023 03:38
@jdetter jdetter marked this pull request as ready for review August 11, 2023 03:40
Boppy and others added 2 commits August 12, 2023 08:23
Simplified Dockerfile
0a0bfc6
@jdetter
Spell Check
6b811f2 
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
@jdetter jdetter changed the title Fix Docker Build Fix Docker Build (dont merge) Aug 12, 2023
@jdetter
Copy link
Collaborator Author

jdetter commented Aug 12, 2023

Closing for now, we're keeping cargo chef for the time being. We merged #181 instead.

@jdetter jdetter closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim left review comments

@drogus drogus Awaiting requested review from drogus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdetter @kim