Remove the expand option on the describe route
#1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Sep 27, 2024
| @@ -222,7 +222,7 @@ impl<'a> EntityDef<'a> { | |||
| } | |||
| } | |||
|
|
|||
| fn entity_description_json(description: WithTypespace<EntityDef>, expand: bool) -> Option<Value> { | |||
| fn entity_description_json(description: WithTypespace<EntityDef>) -> Option<Value> { | |||
There was a problem hiding this comment.
bfops
force-pushed
the
bfops/remove-expand
branch
from
126acd3
to
4d1cb43
Compare
bfops
commented
Sep 27, 2024
| if module_def && expand.is_some() { | ||
| return Err(( | ||
| StatusCode::BAD_REQUEST, | ||
| "expand and module_def cannot both be specified", |
There was a problem hiding this comment.
@coolreader18 why was this constraint here? Does it invalidate the returned thing somehow? (eg something about the typespace?)
There was a problem hiding this comment.
Just because they do opposite things - expand makes the hacky representation more detailed, while module_def uses a non-hacky representation.
…nto bfops/remove-expand
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The
expandoption on thedescriberoute didn't do much - it just omitted theschemafield from the result.This PR removes it, and the corresponding
--brief/-bflag on the CLI subcommand.API and ABI breaking changes
Yes, we're removing some functionality. As far as we know, nobody relies on this.
Expected complexity level and risk
2
Testing
Smoketests still passing