Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gzip + none compression algos and let SDK pick compression #1802

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add gzip + none compression algos and let SDK pick compression #1802

merged 1 commit into from
Oct 9, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 3, 2024 •
edited
Loading

Description of Changes

Adds gzip and none compression choices, and expose it to the rust sdk via DbConnectionBuilder::with_compression.

Fixes #1463.
Closes #1642.

API and ABI breaking changes

None. If a compression is not chosen brotli is used.

@Centril Centril force-pushed the centril/websocket-gzip branch 2 times, most recently from 6d2fbf2 to 4977e33 Compare October 3, 2024 21:03
@Centril Centril mentioned this pull request Oct 3, 2024
Merged
@Centril Centril force-pushed the centril/websocket-gzip branch 2 times, most recently from e481402 to df68663 Compare October 7, 2024 06:45
@cloutiertyler cloutiertyler mentioned this pull request Oct 7, 2024
Closed
gefjon
gefjon approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One doc-comment typo, one request to mark something unstable, one note about low-priority future work. Apply my suggestions, or argue that with_compression should be stable, and then go ahead and merge.

crates/client-api-messages/src/websocket.rs Show resolved Hide resolved
crates/sdk/src/db_connection.rs Show resolved Hide resolved
crates/client-api-messages/Cargo.toml Show resolved Hide resolved
@Centril Centril enabled auto-merge October 8, 2024 17:13
@Centril Centril added this pull request to the merge queue Oct 9, 2024
@Centril Centril removed this pull request from the merge queue due to a manual request Oct 9, 2024
@Centril Centril added this pull request to the merge queue Oct 9, 2024
Merged via the queue into master with commit 1e35fe6 Oct 9, 2024
8 checks passed
@Centril Centril deleted the centril/websocket-gzip branch October 9, 2024 17:28
Centril added a commit to clockworklabs/com.clockworklabs.spacetimedbsdk that referenced this pull request Oct 15, 2024
@Centril
Add gzip + none compression algos and let SDK pick compression (#155)
f1b8fa8 
## Description of Changes

Companion to clockworklabs/SpacetimeDB#1802.

## Requires SpacetimeDB PRs

clockworklabs/SpacetimeDB#1802
@Centril Centril mentioned this pull request Oct 16, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gefjon gefjon gefjon approved these changes

@lcodes lcodes Awaiting requested review from lcodes

@coolreader18 coolreader18 Awaiting requested review from coolreader18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide option for gzip
2 participants
@Centril @gefjon