Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new token format when generating new id tokens #1854

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Conversation

jsdt
Copy link
Contributor

@jsdt jsdt commented Oct 15, 2024

Description of Changes

Send tokens with iss and sub claims, and an identity computed from those. This is compatible with the way we are currently parsing tokens, so it doesn't change much code.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

  1. This is a low risk change that just depends on clients allowing tokens with more fields. When the server parses incoming tokens, we don't require these new fields yet.

Testing

No testing beyond CI checks here and on the corresponding private PR.

@bfops bfops mentioned this pull request Oct 16, 2024
2 tasks
@jsdt jsdt marked this pull request as ready for review October 16, 2024 16:29
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@jsdt jsdt added this pull request to the merge queue Oct 19, 2024
Merged via the queue into master with commit 94eef52 Oct 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants