Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the scheduled_id/at columns be specified in the schema, not by the column name #1861

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

coolreader18
Copy link
Collaborator

Description of Changes

Resolves #1816. Also changes primary_key to be a ColList for future compat reasons.

API and ABI breaking changes

Breaking, yes, but so we can be compatible with future changes.

@coolreader18 coolreader18 force-pushed the noa/schedule-schema branch 3 times, most recently from af9b484 to b4d9765 Compare October 15, 2024 22:05
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much much better.

crates/core/src/host/scheduler.rs Show resolved Hide resolved
crates/schema/src/def.rs Show resolved Hide resolved
crates/schema/src/def/validate/v8.rs Show resolved Hide resolved
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, the parts of it touching the stuff I'm familiar with all look good.

crates/bindings-macro/src/lib.rs Show resolved Hide resolved
@coolreader18 coolreader18 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 209d12c Oct 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule schema should find scheduled_at/id by schema field, not by name
3 participants