bindings: address review comments #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
approved these changes
Jun 29, 2023
| /// This allows later changing the meaning of the returned type variable | ||
| /// if for whatever reason, you cannot provide the full definition of the type yet. | ||
| /// This allows for self referential, | ||
| /// recursive or other complex types to be declared in the typespace. |
There was a problem hiding this comment.
Much improved, thank you 🙏
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* integrate jdetter's review * address phoebe's comments * improve errnos naming
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* integrate jdetter's review * address phoebe's comments * improve errnos naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Addresses review comments in #8.
API
If the API is breaking, please state below what will break
The constants in the
errnosmodule were renamed.