Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete transaction bug #21

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix incomplete transaction bug #21

merged 3 commits into from
Jun 26, 2023

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Jun 26, 2023

Description of Changes

I wrap the usage of Tx inside the vm logic so it correctly deals with an error that must roll back.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@mamcx mamcx requested a review from cloutiertyler June 26, 2023 16:04
@mamcx mamcx enabled auto-merge (squash) June 26, 2023 22:54
@mamcx mamcx merged commit 3d9e58e into master Jun 26, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Fix incomplete transaction bug

* Clippy
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Fix incomplete transaction bug

* Clippy
@cloutiertyler cloutiertyler deleted the mamcx/bug_subscribe branch August 1, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants