Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --locked to building from source instructions #242

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add --locked to building from source instructions #242

merged 1 commit into from
Aug 25, 2023

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Aug 25, 2023 •
edited
Loading

Description of Changes

  • We have an issue right now where clap was updated and they messed something up which requires rust 1.70.0 and we're still on 1.69.0. This improves the reliability of the build.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

gefjon
gefjon approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description includes a typo (a 0 that should be a 1), but the actual change is fine.

@jdetter jdetter enabled auto-merge (squash) August 25, 2023 18:12
@jdetter jdetter merged commit 9ff8273 into master Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gefjon gefjon gefjon approved these changes

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdetter @gefjon