chore: add more tracing to vm #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
requested changes
Aug 28, 2023
| @@ -14,6 +14,7 @@ use spacetimedb_vm::expr::{ColumnOp, CrudExpr, DbType, Expr, QueryExpr, SourceEx | |||
| use spacetimedb_vm::operator::OpCmp; | |||
|
|
|||
| /// Compile the `SQL` expression into a `ast` | |||
| #[tracing::instrument(skip(db, tx))] | |||
| pub fn compile_sql(db: &RelationalDB, tx: &MutTxId, sql_text: &str) -> Result<Vec<CrudExpr>, DBError> { | |||
There was a problem hiding this comment.
This function has 2 major steps: compile_to_ast for parsing the sql and compile_statement to turn that into our ast. I think is redundant to have compile_to_ast here or if wanna see the cost then add the loop that call compile_statement.
There was a problem hiding this comment.
You're right, I removed the instrumentation from compile_to_ast
joshua-spacetime
force-pushed
the
joshua/tracing
branch
from
4aeff21
to
eb63d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI
If the API is breaking, please state below what will break