Enable restart tests #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/enable-restart-tests
branch
from
f7489b5
to
ff65bf8
Compare
Centril
reviewed
Jun 29, 2023
Comment on lines
417
to
420
| let rows = st_tables.scan_rows().cloned().collect::<Vec<_>>(); | ||
| for row in rows { |
There was a problem hiding this comment.
Let's clarify why we collect to then immediately iterate.
Comment on lines
993
to
996
| .map(|tx_state| tx_state.insert_tables.contains_key(table_id)) | ||
| .unwrap_or(false) |
There was a problem hiding this comment.
Suggested change
| .map(|tx_state| tx_state.insert_tables.contains_key(table_id)) | |
| .unwrap_or(false) | |
| .map_or(false, |tx_state| tx_state.insert_tables.contains_key(table_id)) |
Comment on lines
1414
to
1422
| // Honestly this should maybe just be one big procedure. | ||
| // See John Carmack's philosophy on this. |
There was a problem hiding this comment.
I much prefer the style of code you've written here to Carmack's philosophy.
| Ok(()) | ||
| } | ||
|
|
||
| pub fn replay_transaction( |
Comment on lines
1539
to
1547
| Some(RowOp::Insert) => (), // Do nothing, we'll get it in the next stage | ||
| Some(RowOp::Delete) => (), // Skip it, it's been deleted |
There was a problem hiding this comment.
Suggested change
| Some(RowOp::Insert) => (), // Do nothing, we'll get it in the next stage | |
| Some(RowOp::Delete) => (), // Skip it, it's been deleted | |
| Some(RowOp::Insert) => {}, // Do nothing, we'll get it in the next stage. | |
| Some(RowOp::Delete) => {}, // Skip it, it's been deleted. |
Comment on lines
1541
to
1553
| Some(RowOp::Absent) => { | ||
| return Some(DataRef::new(row.clone())); | ||
| } | ||
| None => { | ||
| return Some(DataRef::new(row.clone())); | ||
| } |
There was a problem hiding this comment.
Suggested change
| Some(RowOp::Absent) => { | |
| return Some(DataRef::new(row.clone())); | |
| } | |
| None => { | |
| return Some(DataRef::new(row.clone())); | |
| } | |
| Some(RowOp::Absent) | => None => { | |
| return Some(DataRef::new(row.clone())); | |
| } |
Comment on lines
1551
to
1560
| .tx_state | ||
| .as_ref() | ||
| .and_then(|tx_state| tx_state.insert_tables.get(&self.table_id)) |
jdetter
force-pushed
the
jdetter/enable-restart-tests
branch
from
d5da512
to
6d7bd2e
Compare
jdetter
force-pushed
the
jdetter/enable-restart-tests
branch
2 times, most recently
from
fa19e65
to
94c8fa9
Compare
cloutiertyler
force-pushed
the
jdetter/enable-restart-tests
branch
from
94c8fa9
to
d5da512
Compare
cloutiertyler
force-pushed
the
jdetter/enable-restart-tests
branch
from
d5da512
to
0127fbc
Compare
cloutiertyler
added a commit
that referenced
this pull request
Aug 1, 2023
* Fixes the restart problem (i.e. rebuilding the datastore from the message log) * Remove logging * Enable restart tests * Fixed small issues with tests * Fixed restart-repeating-reducer test probably --------- Co-authored-by: Tyler Cloutier <cloutiertyler@aol.com> Co-authored-by: Boppy <no-reply@boppygames.gg>
cloutiertyler
added a commit
that referenced
this pull request
Aug 1, 2023
* Fixes the restart problem (i.e. rebuilding the datastore from the message log) * Remove logging * Enable restart tests * Fixed small issues with tests * Fixed restart-repeating-reducer test probably --------- Co-authored-by: Tyler Cloutier <cloutiertyler@aol.com> Co-authored-by: Boppy <no-reply@boppygames.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
API
If the API is breaking, please state below what will break