Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ArrayValue, ArrayType, MapValue, MapType to own files #387

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Extract ArrayValue, ArrayType, MapValue, MapType to own files #387

merged 4 commits into from
Oct 9, 2023

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 9, 2023

Description of Changes

Moves ArrayValue, ArrayType, MapValue, and MapType to their own files.

Extracted from #379 to facilitate review.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

kim
kim approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reorganizes code, so LGTM

@Centril Centril merged commit 0a30c02 into master Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @kim