Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten BuiltinValue into AlgebraicValue #389

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Flatten BuiltinValue into AlgebraicValue #389

merged 1 commit into from
Oct 9, 2023

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 9, 2023

Description of Changes

Flattens BuiltinValue into AlgebraicValue to facilitate #156.
This does not flatten the type structure.
Therefore there is no ABI break as BuiltinValue was never noticeable in BSATN.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

mamcx
mamcx approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Centril Centril merged commit ff69ec4 into master Oct 9, 2023
5 checks passed
@drogus
Copy link
Collaborator

drogus commented Oct 9, 2023

benchmarks please

@drogus drogus deleted the flatten-value branch October 10, 2023 11:38
@drogus drogus restored the flatten-value branch October 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Centril @drogus @mamcx