Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor system_tables + locking_tx_datastore tests with functions #391

Closed
wants to merge 2 commits into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 9, 2023

Description of Changes

Adds some helper functions like column_row that help out in system_tables and in locking_tx_datastore tests.
This helps out with SATS shrinking by dealing with strings in a more central location. (first commit)

Also simplifies some test setup code (second commit).

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to the systems_table.rs file. See my comment inline for informatino.

@@ -248,36 +260,13 @@ pub fn st_table_schema() -> TableSchema {
is_unique: true,
},
],
columns: vec![
Copy link
Contributor

@cloutiertyler cloutiertyler Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to veto these changes. This is some of the most critical code in the whole system, and the changes here make it more difficult to read and less obvious as to what is really going on. Particularly with the field names not inline like they were. The additional level of indirection just adds potential for confusion. This code is only going to be written once but read many times.

Additionally this change seems unrelated to Sats, no?

@Centril
Copy link
Contributor Author

Centril commented Oct 10, 2023

Closing, see Tyler's comment above :)

@Centril Centril closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants