feat(397): Add min and max value helpers for builtin types #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested changes
Oct 10, 2023
joshua-spacetime
force-pushed
the
joshua/397/max-values-for-builtin-types
branch
from
f14b198
to
bc818d6
Compare
joshua-spacetime
force-pushed
the
joshua/397/max-values-for-builtin-types
branch
from
bc818d6
to
225320e
Compare
Fixes #397. Adding these helpers for computing multidimensional index bounds. Any unbounded or infinite dimensions need to be made finite by computing the min or max value for the type of said dimension. For example ``` a < 5 and b < 6 ``` needs to become ``` a >= MIN and a < 5 and b >= MIN and b < 5 ```
joshua-spacetime
force-pushed
the
joshua/397/max-values-for-builtin-types
branch
from
225320e
to
714ac21
Compare
Centril
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397.
Adding these helpers for computing multidimensional index bounds. Any unbounded or infinite dimensions need to be made finite by computing the min or max value for the type of said dimension.
For example
needs to become
Description of Changes
API and ABI
If the API is breaking, please state below what will break