-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindings-macro: add note re. autoinc #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks a bit odd having those notes, but nothing else about the grammar or semantics of the macro. Didn't we have a ticket for documenting the macro?
Co-authored-by: Kim Altintop <kim@eagain.io> Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this works.
I would intuitively translate those attributes to SQL, so questions of which can / should be combined didn't arise. Maybe we can draw that analogy more often, as we seem to default to SQL semantics airquotes-unless-otherwise-noted.
* bindings-macro: add note re. autoinc * Update crates/bindings-macro/src/lib.rs Co-authored-by: Kim Altintop <kim@eagain.io> Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> * spacetimedb_tabletype: minor docs tweaks * address pheobe's review --------- Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Kim Altintop <kim@eagain.io>
* bindings-macro: add note re. autoinc * Update crates/bindings-macro/src/lib.rs Co-authored-by: Kim Altintop <kim@eagain.io> Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> * spacetimedb_tabletype: minor docs tweaks * address pheobe's review --------- Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Kim Altintop <kim@eagain.io>
Description of Changes
Adds documentation on
#[autoinc]
not implying#[unique]
/#[primarykey]
per discussion on Discord.API
If the API is breaking, please state below what will break