Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in assigment of PK constraints & creation of associated index #74

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Jul 12, 2023

Description of Changes

..and upgrade SQL parsing.

Now this syntax is correctly parsed:

CREATE TABLE e (inventory_id BIGINT GENERATED BY DEFAULT AS IDENTITY); --Identity
CREATE TABLE d (inventory_id BIGINT PRIMARY KEY); --PrimaryKey
CREATE TABLE f (inventory_id BIGINT PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY); --PrimaryKeyAuto

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@mamcx mamcx requested a review from RReverser July 12, 2023 18:52
Copy link
Member

@RReverser RReverser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line I was concerned about looks good, but I'm not sure I'm qualified to review the rest 😅

@mamcx mamcx merged commit 59c26f9 into master Jul 13, 2023
4 checks passed
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
@cloutiertyler cloutiertyler deleted the mamcx/fix_pk_vm branch August 1, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants