Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Functions for saving and loading Credentials to/from disk #84

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

gefjon
Copy link
Contributor

@gefjon gefjon commented Jul 17, 2023

Description of Changes

This commit adds two functions to the Rust SDK, identity::save_credentials and identity::load_credentials, which abstract over the common desire to save a user's credentials to a file in (a subdir of) ~, and load it when re-connecting.

In addition to de-duplicating common functionality, this allows us to remove a relatively complex section of the Rust SDK Quickstart guide.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but this is fine to include, we similar functionality in both the python and C# SDK (optional identity/token management helper functions)

@gefjon gefjon merged commit 788a3f7 into master Jul 18, 2023
4 checks passed
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
[SDK] Functions for saving and loading `Credentials` to/from disk

This commit adds two functions to the Rust SDK, identity::save_credentials and identity::load_credentials, which abstract over the common desire to save a user's credentials to a file in (a subdir of) ~, and load it when re-connecting.

In addition to de-duplicating common functionality, this allows us to remove a relatively complex section of the Rust SDK Quickstart guide.
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
[SDK] Functions for saving and loading `Credentials` to/from disk

This commit adds two functions to the Rust SDK, identity::save_credentials and identity::load_credentials, which abstract over the common desire to save a user's credentials to a file in (a subdir of) ~, and load it when re-connecting.

In addition to de-duplicating common functionality, this allows us to remove a relatively complex section of the Rust SDK Quickstart guide.
@cloutiertyler cloutiertyler deleted the phoebe/sdk-save-creds-load-creds branch August 1, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants