Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate types to SpacetimeDB.Types namespace #88

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

dbrinkmanncw
Copy link
Contributor

Description of Changes

NOTE: This will break existing CSharp projects and Unity projects when they update.

Accompanying SDK PR: clockworklabs/com.clockworklabs.spacetimedbsdk#41

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

crates/cli/src/subcommands/generate/csharp.rs Outdated Show resolved Hide resolved
crates/cli/src/subcommands/generate/csharp.rs Outdated Show resolved Hide resolved
crates/cli/src/subcommands/generate/mod.rs Outdated Show resolved Hide resolved
@dbrinkmanncw
Copy link
Contributor Author

Changes pushed

@dbrinkmanncw dbrinkmanncw merged commit ad7bc6c into master Jul 27, 2023
4 checks passed
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* generate types to SpacetimeDB.Types namespace

* Add Reducer partial class to csharp codegen to tag it with the ReducerClass attribute

* Changes based on feedback

* Fix SpacetimeDB tests

* One more smoketest fix

---------

Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* generate types to SpacetimeDB.Types namespace

* Add Reducer partial class to csharp codegen to tag it with the ReducerClass attribute

* Changes based on feedback

* Fix SpacetimeDB tests

* One more smoketest fix

---------

Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
@cloutiertyler cloutiertyler deleted the generate-types-to-namespace branch August 1, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants