Fix Fragile Smoketest #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
commented
Jul 20, 2023
| token.cancel(); | ||
| let token = spacetimedb::schedule!("100ms", reducer(2)); | ||
| spacetimedb::schedule!("50ms", do_cancel(token)); |
There was a problem hiding this comment.
I'm just creating wider margins here so the test isn't so fragile when the runner is busy.
gefjon
approved these changes
Jul 20, 2023
Centril
approved these changes
Jul 20, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Boppy <no-reply@boppygames.gg>
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Boppy <no-reply@boppygames.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
cancel-reducersmoketest sometimes fails when the github runner is especially busy. Basically SpacetimeDB isn't able to cancel the test reducer before it executes because SpacetimeDB is too busy running other tests.API
If the API is breaking, please state below what will break