[Modules] spacetimedb(index) macro now uses more consistent parens.
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this comment, the `#[spacetimedb(index)]` attribute accepted its arguments like: ```rust ``` This was weird and bad. Putting the `NAME` and `FIELD_NAMES` arguments outside of the inner parens was uninutitive. With this commit, the syntax is changed to: ```rust ```
cloutiertyler
approved these changes
Jul 24, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
…#97) Prior to this comment, the `#[spacetimedb(index)]` attribute accepted its arguments like: ```rust \#[spacetimedb(index(btree), name = "NAME", FIELD_NAMES...)] ``` Putting the `NAME` and `FIELD_NAMES` arguments outside of the inner parens was uninutitive. With this commit, the syntax is changed to: ```rust \#[spacetimedb(index(btree, name = "NAME", FIELD_NAMES...))] ```
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
…#97) Prior to this comment, the `#[spacetimedb(index)]` attribute accepted its arguments like: ```rust \#[spacetimedb(index(btree), name = "NAME", FIELD_NAMES...)] ``` Putting the `NAME` and `FIELD_NAMES` arguments outside of the inner parens was uninutitive. With this commit, the syntax is changed to: ```rust \#[spacetimedb(index(btree, name = "NAME", FIELD_NAMES...))] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Prior to this comment, the
#[spacetimedb(index)]attribute accepted its arguments like:#[spacetimedb(index(btree), name = "NAME", FIELD_NAMES...)]This was weird and bad. Putting the
NAMEandFIELD_NAMESarguments outside of the inner parens was uninutitive. With this commit, the syntax is changed to:#[spacetimedb(index(btree, name = "NAME", FIELD_NAMES...))]API
If the API is breaking, please state below what will break
The syntax of
#[spacetimedb(index)]has changed. Module authors will need to grep for index declarations and alter the parens around the arguments.