Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Identity from UInt8Array to Identity to match other SDKs #14

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

dbrinkmanncw
Copy link
Contributor

@dbrinkmanncw dbrinkmanncw commented Jul 21, 2023

Description of Changes

Describe what has been changed, any new features or bug fixes

UInt8Array -> Identity
Reducer callbacks now get a ReducerEvent instead of just caller and status

API

  • [X ] This is an API breaking change to the SDK

If the API is breaking, please state below what will break

Projects using this SDK will need to:

  • update their references to identities from UInt8Arrays to Identity
  • update any reducer callbacks to take a ReducerEvent as the first argument

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

clockworklabs/SpacetimeDB#94

Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Identity in places like readme.md, client_api.ts (like export interface Event), App.tsx, spacetimedb_client.ts are not updated with the new class.

Is likely some take advantage of weak typing, but wonder if is the desirable outcome.

Copy link
Collaborator

@drogus drogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mamcx mamcx merged commit c54aa4b into main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants