-
-
Notifications
You must be signed in to change notification settings - Fork 645
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
This is for nbb, scittle, joyride. Better support for "pain" repls, support "cljs" without setup. We want to: 1. connect with a plain nREPL client 2. make any assumptions explicit about the nREPL server/runtime 3. connect cljs buffers with those plain repls 1. Check for cider middleware being present, before using it (already being done) 2. Check for cider-library-present-p, before relying on anything in the runtime. 3. Make assumptions about the runtime explicit My suggestion is to solve these problems is `cider-connection-capabilities`. Currently, there was an implicit assumption about the compilation error format. Changes to `cider-repls`: Now returns cljs, if the repl capabilities include 'cljs. This way we can make a "plain" clj client, upgrade on connect with cljs capability and have it be connected in cljs buffers. This is more a concession / workaround the current repl-type setup. Here's the slack discussion that lead to this PR: https://clojurians.slack.com/archives/C04CAKAGADU
- Loading branch information
1 parent
5064287
commit 24b9891
Showing
9 changed files
with
108 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
= Scittle, Nbb, Joyride, and future plain repls | ||
|
||
The default cider (clj-repl) should be capable of connecting to any | ||
nrepl server that provides minimal functionality. | ||
|
||
As such, all of these work: | ||
https://github.com/babashka/nbb[nbb], | ||
https://github.com/babashka/scittle[scittle], https://github.com/BetterThanTomorrow/joyride[joyride] | ||
|
||
First start an nrepl server (the project's Readme usually has a section | ||
on starting a nrepl server). | ||
|
||
You can use | ||
|
||
kbd:[M-x `cider-connect-clj` <RET>] | ||
|
||
to connect to any plain Clojure(Script) nrepl server. | ||
|
||
Features: | ||
|
||
* Eval, load file etc. | ||
* Errors as overlays. (The default cider error buffer is not implemented currently). | ||
* Other nrepl features the server provides; This might be rather minimal. | ||
Nbb, Scittle and Joyride all have quite cool completions already. | ||
|
||
== Note | ||
|
||
For nbb you can alternatively connect via cljs, see xref:platform/nbb.adoc[Nbb] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters