Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no cider-turn-on-eldoc-mode #934

Closed
ghost opened this issue Dec 30, 2014 · 3 comments
Closed

There is no cider-turn-on-eldoc-mode #934

ghost opened this issue Dec 30, 2014 · 3 comments

Comments

@ghost
Copy link

ghost commented Dec 30, 2014

Firstly, thanks for your great plugin.
I try to use cider with my emacs, I don't seem to make cider-eldoc working. The cider-turn-on-eldoc-mode is not available in my Emacs. Am I missing anything ?
@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

It's defined here.

@vspinu
Copy link
Contributor

vspinu commented Dec 30, 2014

It's defined here.

Is this really needed?

eldoc is generic and eldoc-mode should be more than enough if eldoc-documentation-function has been defined.

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

Yes, this can be optimized. It's legacy code.

On Tuesday, December 30, 2014, Vitalie Spinu notifications@github.com
wrote:

It's defined here.

Is this really needed?

eldoc is generic and eldoc-mode should be more than enough if
eldoc-documentation-function has been defined.

—
Reply to this email directly or view it on GitHub
#934 (comment).

Best Regards,
Bozhidar Batsov

http://www.batsov.com

@bbatsov bbatsov closed this as completed in 1b1bb3c Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @vspinu