-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate overlays with interactive evaluation #1201
Conversation
Just one comment from me - won't it better to have the option select either |
Done. I also set the default duration of overlays to be "until next command" which mimics the echo-area. |
Integrate overlays with interactive evaluation
👍 Looks good to me. Not sure about the default value for |
👍 yey more pretty! |
👍 And I'm not sure about the default value either. |
Here's a data point for the default-value discussion. When you get a result of several lines, having it print in both places will completely take up the window. |
@Malabarba Maybe we should just leave the old version as the default and add a note and a screenshot to the README, regarding the overlays. I'm totally fine with making them the default as well, I'm just worried about potential bugs, as this hasn't been tested that extensively yet. |
@bbatsov Yes, I've been using it and uncovering a few corner cases. There'll be a PR related to that soon. |
You're a mind reader - this is exactly what I've been thinking about. It makes a lot of sense to solicit feedback about the feature right now, so let's leave it on until the release. |
Closes #1196