Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1239] Add cider-refresh-show-log-buffer #1260

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

cichli
Copy link
Member

@cichli cichli commented Aug 16, 2015

Been using this for the past couple of days - definitely preferable to have it nil by default. Since the error buffer pops up when something goes wrong, the refresh log is only really useful to show when debugging using the output of the before/after fns.

Maybe a cider-visit-refresh-log-buffer command would be useful for quickly popping up the refresh log on demand - or add it as an option to the selector?

(log message face)
(unless cider-refresh-show-log-buffer
(let ((message-truncate-lines t))
(message "cider-refresh: %s" (s-trim message))))))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why cl-flet* indents so strangely. I'd almost prefer to use plain let* and lambda.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also cl-labels.

@bbatsov
Copy link
Member

bbatsov commented Aug 16, 2015

Since the error buffer pops up when something goes wrong, the refresh log is only really useful to show when debugging using the output of the before/after fns.

Guess you can mention this in the troubleshooting section. :-)

@cichli cichli force-pushed the refresh-echo-area branch from 993c173 to 15baece Compare August 16, 2015 20:34
@cichli
Copy link
Member Author

cichli commented Aug 16, 2015

I've added a note under the reloading section - the troubleshooting section seems to be more for diagnosing problems with CIDER itself (to clarify - I meant the output of the before/after fns is useful for debugging your own program :-)).

bbatsov added a commit that referenced this pull request Aug 17, 2015
[Fix #1239] Add cider-refresh-show-log-buffer
@bbatsov bbatsov merged commit a1e4d7c into clojure-emacs:master Aug 17, 2015
@bbatsov
Copy link
Member

bbatsov commented Aug 17, 2015

I've added a note under the reloading section - the troubleshooting section seems to be more for diagnosing problems with CIDER itself (to clarify - I meant the output of the before/after fns is useful for debugging your own program :-)).

Good point. 👍

@cichli cichli deleted the refresh-echo-area branch September 15, 2015 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants