Reconnect to the same host:port after cider-restart if the connection was established with cider-connect
#1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jan 3, 2017
| (buf-name (buffer-name conn))) | ||
| (buf-name (buffer-name conn)) | ||
| ;; save these variables before we kill the connection | ||
| (conn-type (with-current-buffer conn cider-connection-created-with)) |
There was a problem hiding this comment.
conn-type is a bit misleading here. Maybe conn-creation-method?
bbatsov
reviewed
Jan 3, 2017
| @@ -245,6 +245,10 @@ namespace-qualified function of zero arity." | |||
| map) | |||
| "Minibuffer keymap used for reading Clojure expressions.") | |||
|
|
|||
| (defvar-local cider-connection-created-with 'jack-in | |||
| "Save how the connection was created. Its value can be either 'jack-in or | |||
There was a problem hiding this comment.
The second sentence should be on a separate line.
bbatsov
reviewed
Jan 3, 2017
| (let ((default-directory project-dir)) | ||
| (cider-jack-in)) | ||
| (error "Can't restart CIDER connection for unknown project")))) | ||
| (if (eq conn-type 'connect) |
There was a problem hiding this comment.
I guess you can make this a pcase and add some error handling in case the conn-type is unexpectedly something different than the two possible values.
|
It's good to have you back! I've added a few small remarks. |
|
Done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I've worked on anything in CIDER. Feels good to be back :-)
This PR fixes #1895.
@bbatsov, the approach is the same as what you outlined in the comment.
cider-connection-created-withto track how the connection was created. It defaults to'jack-in, and we set it to'connectincider-connect.cider--restart-connection, we do the right thing based on the type ofconn.make test)M-x checkdocwarningsThanks!