require and in-ns ns in separate forms for cider-repl-set-ns

[tomdl89]

I think I had to create a new nrepl response handler in order to ensure it wouldn't cause two new prompts. Tested in two cljs environments, where it works fine. Feedback very welcome!

[dpsutton]

That handler should have a docstring indicating its subtle behavior: to swallow the nil that comes back from requiring. I always go back and forth if the name should be what it does, ie cider-repl-value-ignoring-repl-handler instead of cider-repl-require-ns-handler and then the call site gives it its meaning. Oh, this code requires the namespace but ignores the return value (which is always nil?)

[tomdl89]

fix for #2993

[bbatsov]

Do we really need an extra handler for this? Seems to me that we can just do a sync eval for the require and then trigger the async eval for the in-ns. This should result in code that's more straightforward IMO.

[bbatsov]

Here I'd just do a sync eval of the require and we should be good.

[tomdl89]

awesome! I had a feeling there would be a more concise way of doing this. thanks

[bbatsov]

Don't forget the connection param here.

[tomdl89]

and the ns param?

[bbatsov]

It's not needed in this case.

[bbatsov]

Thanks!