Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3012 - allow connect-sibling from any buffer #3013

Merged
merged 2 commits into from
May 8, 2021

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented May 8, 2021

Fixes #3012


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@bbatsov bbatsov merged commit 7c86bfa into clojure-emacs:master May 8, 2021
@bbatsov
Copy link
Member

bbatsov commented May 8, 2021

Looks good. Thanks!

Note to self - we should replace this nil with 'infer at some point, so such code is easier to read/understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintuitive behaviour of cider-connect-sibling
2 participants