Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cider-stacktrace-analyze-in-region #3247

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

r0man
Copy link
Contributor

@r0man r0man commented Sep 18, 2022

Add command to analyze and inspect the stacktrace in region

Please see:


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@vemv
Copy link
Member

vemv commented Sep 19, 2022

Another thing that you may be interested in to do is making a stacktrace 'clickable'.

Often when a repl command emits a stacktrace, each element of that stacktrace is clickable, taking you to the right file/line. (I think if you grep for fontify you will find the related mechanism we use?)

That seems super handy as it's an "inline UI". For instance I might paste a stacktrace from Datadog into *scratch* and just leave it there for a while.

If it turns out to be disproportionately hard, then it's no big deal.

@bbatsov
Copy link
Member

bbatsov commented Sep 19, 2022

Another thing that you may be interested in to do is making a stacktrace 'clickable'.

Clickable in what way? Even now you can click on stack frames and go to the revelant source code.

@vemv
Copy link
Member

vemv commented Sep 19, 2022

I mean an arbitrary one e.g. pasted from the clipboard

@bbatsov
Copy link
Member

bbatsov commented Sep 19, 2022

The new command should be mentioned somewhere in the mode menu and in the "dealing with stacktraces" docs.

@r0man r0man force-pushed the stacktrace-at-point branch from bdf7c0d to 1c27c1d Compare October 3, 2022 08:50
@r0man r0man force-pushed the stacktrace-at-point branch 2 times, most recently from c71c709 to a8267f8 Compare October 14, 2022 16:43
@bbatsov
Copy link
Member

bbatsov commented Oct 28, 2022

I guess we're mostly ready here and we'll move forward with a proper review after the stacktrace-related code is moved to haystack and haystack is integrated into cider-nrepl.

r0man added 2 commits December 5, 2022 13:15
This PR adds the `cider-stacktrace-analyze-at-point` and
`cider-stacktrace-analyze-in-region` commands to view printed
exceptions in the stacktrace inspector.
@r0man r0man force-pushed the stacktrace-at-point branch from 0d0633a to 0e54ca5 Compare December 5, 2022 12:16
@bbatsov bbatsov merged commit c132951 into clojure-emacs:master Dec 5, 2022
@bbatsov
Copy link
Member

bbatsov commented Dec 5, 2022

It was an epic journey but we've made it to our destination! 🎉 Thanks for you persistence on this one and the amazing work you've done across the board! 🙇‍♂️

@r0man
Copy link
Contributor Author

r0man commented Dec 5, 2022

Nice, also thanks to you and @vemv and @benedekfazekas for all the help. See you next time!

@vemv
Copy link
Member

vemv commented Dec 6, 2022

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants