-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cider-stacktrace-analyze-in-region #3247
Conversation
Another thing that you may be interested in to do is making a stacktrace 'clickable'. Often when a repl command emits a stacktrace, each element of that stacktrace is clickable, taking you to the right file/line. (I think if you grep for That seems super handy as it's an "inline UI". For instance I might paste a stacktrace from Datadog into If it turns out to be disproportionately hard, then it's no big deal. |
Clickable in what way? Even now you can click on stack frames and go to the revelant source code. |
I mean an arbitrary one e.g. pasted from the clipboard |
The new command should be mentioned somewhere in the mode menu and in the "dealing with stacktraces" docs. |
bdf7c0d
to
1c27c1d
Compare
c71c709
to
a8267f8
Compare
I guess we're mostly ready here and we'll move forward with a proper review after the stacktrace-related code is moved to haystack and haystack is integrated into cider-nrepl. |
This PR adds the `cider-stacktrace-analyze-at-point` and `cider-stacktrace-analyze-in-region` commands to view printed exceptions in the stacktrace inspector.
0d0633a
to
0e54ca5
Compare
It was an epic journey but we've made it to our destination! 🎉 Thanks for you persistence on this one and the amazing work you've done across the board! 🙇♂️ |
Nice, also thanks to you and @vemv and @benedekfazekas for all the help. See you next time! |
Cheers 🍻 |
Add command to analyze and inspect the stacktrace in region
Please see:
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.