Scroll repl buffer in other frame #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please mention this in the changelog? |
after using cider-insert-in-repl.
pdbrown
force-pushed
the
fix/scroll-repl-other-frame
branch
from
032819b to
59eeafe
Compare
|
Yep! Added a note to the changelog. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little fix to make the repl buffer scroll to the bottom after
cider-insert-in-replwhen it's in another frame. It doesn't currently scroll in other frames becauseget-buffer-windowonly considers the current one by default. Setting the opt argtmeans to consider all windows on all existing frames (and seems to start with the selected frame).