nrepl-bdecode-buffer did not handle negative integers. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threw a silent (and therefore nasty) bug that froze the repl when a large stack trace contained a negative number. Regex now modified to accept an optional leading negative.
| @@ -185,7 +185,7 @@ To be used for tooling calls (i.e. completion, eldoc, etc)") | |||
| ;;; and modified to work with utf-8 | |||
| (defun nrepl-bdecode-buffer () | |||
| "Decode a bencoded string in the current buffer starting at point." | |||
| (cond ((looking-at "i\\([0-9]+\\)e") | |||
| (cond ((looking-at "i\\(-*[0-9]+\\)e") | |||
There was a problem hiding this comment.
Shouldn't this be -? as there will always be just one - or none.
|
You should also add a test for that. |
bbatsov
added a commit
that referenced
this pull request
May 23, 2014
nrepl-bdecode-buffer did not handle negative integers.
bbatsov
pushed a commit
that referenced
this pull request
May 23, 2014
|
I added a test myself just now, since it turned out this was related to another major problem (clojure-emacs/cider-nrepl#68) and I wanted to merge your fix ASAP. Thanks a lot for hunting this down! |
|
I found this bug precisely because of that problem (stack trace). So its really the same user issue. |
|
@violahs Good find. This was a particularly nasty one. Quite a headache for just 2 characters... |
dgtized
pushed a commit
to dgtized/cider
that referenced
this pull request
Jun 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threw a silent (and therefore nasty) bug that froze the repl when a large
stack trace contained a negative number.
Regex now modified to accept an optional leading negative.