Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macroexpansion #705

Closed

Conversation

hugoduncan
Copy link
Member

Macro expansion was giveing a "nrepl-netstring: Wrong type argument: stringp,
tidy" message. This calls symbol-name on
cider-macroexpansion-suppress-namespaces before passing it to
nrepl-send-request-sync.

Macro expansion was giveing a "nrepl-netstring: Wrong type argument: stringp,
tidy" message.  This calls symbol-name on
cider-macroexpansion-suppress-namespaces before passing it to
nrepl-send-request-sync.
@bbatsov
Copy link
Member

bbatsov commented Aug 6, 2014

This would require a middleware update as well - nil used to be encoded as an empty vector, now it won't be. I think if we changed the 3 config options to symbols - perhaps never, tidy and always. This would simplify the code a bit. The booleans made sense when this was on/off, but now - not so much.

@hugoduncan
Copy link
Member Author

Having all cases be symbols definitely looks like it would be cleaner. I don't have time to fix this at the moment. @tsdh would you be able to take a look at it?

@bbatsov
Copy link
Member

bbatsov commented Aug 6, 2014

@tsdh You might even change the name of the defcustom to something like cider-macroexpansion-namespace-display. Seems to it makes more sense.

@tsdh
Copy link
Contributor

tsdh commented Aug 6, 2014

@bbatsov, @hugoduncan I'm currently on a trip and won't return until Monday. If the issue is still there at that point in time, I'll take care of it.

@bbatsov
Copy link
Member

bbatsov commented Aug 7, 2014

OK. I'll probably won't have time for it today, but might be able to fix it tomorrow.

@bbatsov bbatsov closed this in 30d60b1 Aug 8, 2014
bbatsov added a commit to clojure-emacs/cider-nrepl that referenced this pull request Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants