Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #595 #612] Fix infinite loop when reverse searching for next definition #624

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

OknoLombarda
Copy link
Contributor

@OknoLombarda OknoLombarda commented Jul 16, 2022

Fixes #595
Fixes #612

Fix infinite loop in clojure-match-next-def when typing metadata in def forms. Some more context here.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking reasonable!

Some suggestions for code coverage, will eye the impl again afterwards

clojure-mode.el Show resolved Hide resolved
test/clojure-mode-syntax-test.el Outdated Show resolved Hide resolved
test/clojure-mode-syntax-test.el Outdated Show resolved Hide resolved
@OknoLombarda OknoLombarda force-pushed the fix-infinite-loop-on-metadata branch from a7c9d66 to 073d18e Compare July 17, 2022 09:14
@vemv
Copy link
Member

vemv commented Jul 19, 2022

Great work!

I verified that if one discards the fix but keeps the tests, said tests indeed loop forever: https://app.circleci.com/pipelines/github/clojure-emacs/clojure-mode/261/workflows/9315c32d-6ac0-40e0-a7ef-e16eb51218d2/jobs/899

@vemv vemv merged commit 54a62cc into clojure-emacs:master Jul 19, 2022
@OknoLombarda OknoLombarda deleted the fix-infinite-loop-on-metadata branch July 19, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer freezes on (def ^{:macro}) Syntax ^: causes Emacs to freeze.
2 participants