Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate an incompatibility with clojure.java.classpath #112

Closed
wants to merge 1 commit into from

Conversation

vemv
Copy link
Member

@vemv vemv commented Apr 11, 2021

See also: clojure-emacs/cider-nrepl#668
See also: #103

This PR intends to demonstrate as precisely/isolatedly as possible how the current implementation of orchard.java creates issues for outside libraries such as clojure.java.classpath, and transitively, clojure.tools.namespace.

As predicted, it fails for JDK >= 11:

image

FWIW, I tried to actually fix the issue, for example using this pattern seemed promising:

(let [c (current-classloader)]
  (try
    ...
    (finally
      (set-classloader c))))

No luck though.

vemv added a commit to reducecombine/orchard that referenced this pull request Apr 11, 2021
vemv added a commit to reducecombine/orchard that referenced this pull request Apr 11, 2021
vemv added a commit to reducecombine/orchard that referenced this pull request Apr 11, 2021
vemv added a commit to reducecombine/orchard that referenced this pull request Apr 13, 2021
vemv added a commit to reducecombine/orchard that referenced this pull request Apr 13, 2021
vemv added a commit to reducecombine/orchard that referenced this pull request Apr 13, 2021
@bbatsov bbatsov closed this in #114 Apr 13, 2021
bbatsov pushed a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant