WIP - Retrieve java classes with resolve and fix #86 again #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 20, 2020
src/orchard/info.clj
Outdated
| {:pre [(= dialect :clj)]} | ||
| (println "###") |
There was a problem hiding this comment.
It's much easier to debug with the debugger. ;-)
arichiardi
force-pushed
the
fix-86-2
branch
2 times, most recently
from
b8fe44c to
f4670e7
Compare
This patch unfixes clojure-emacs#86. It basically tries to restore a more linear flow in clj-info and orchard.java, distinguishing a bit more between qualified and unqualified patterns.
|
Any updates here? |
|
Partly yes, but it also appears that this PR proposes some valuable refinements for Java class/method resolution. At the same time if refining them we should come up with some failing tests cases first so we can see what is wrong (probably not much at this point!). I believe closing this PR is the right thing simply for not inviting the author to waste time solving merge conflicts for a mostly-addressed problem. I'd want to favor small diffs that solve one problem at a time / won't solve again what we already got right. However we can try again from scratch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done:
Please don't merge! 😄