-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower bandwidth at startup #264
Lower bandwidth at startup #264
Conversation
This addresses #263. I couldn't get ./build install to run without errors even before I made these changes. Let's see if circleci passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this! 👍
Cool I'll make those changes. I'm having a hard time testing this in emacs, how do you go about testing this within emacs? When I do a lein install, I don't get the same behavior as when I run in the a separate lein repl (with the appropriate profiles). Maybe I should try renaming the project and deploy to my personal clojars to get it to work. |
runnig ./build install i get the following: |
I think I know my issue with build.sh, I keep forgetting about the proper profile. |
Testing in emacs is giving me different behavior. It's downloading on every invocation of jack-in. It is getting the gzipped version at least :-). |
Is make inline-deps always required before I do lein install? |
ah! :force true is set! why!? |
Ah, ok it's not a bug. The default custom variable cljr-populate-artifact-cache-on-startup is true. Changing it to nil fixes the issue. I might open an issue there just as a reminder. |
One more thing I should change I should either keep the map sorted or resort it when loading from cache file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than a final nitpick! 👍
Thanks! |
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
lein do clean, test
)./build.sh install
-- takes a long time)Thanks!