Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies #34

Closed
wants to merge 1 commit into from
Closed

bump dependencies #34

wants to merge 1 commit into from

Conversation

dgellow
Copy link

@dgellow dgellow commented Dec 8, 2014

No description provided.

@dgellow
Copy link
Author

dgellow commented Dec 8, 2014

It works for me™.
Tested with lein midje :autotest and my current project.

@dgellow
Copy link
Author

dgellow commented Dec 8, 2014

@ddellacosta It is necessary to solve a conflict between friend and clj-http.
Both depend on [org.apache.httpcomponents/httpclient], but friend 2.0.0 depends on 4.2.1 and clj-http 1.0.1 on 4.3.5.

If friend is before clj-http in the dependencies vector, it will load the version 4.2.1 and crash when clj-http will be called.

So, we can exclude httpclient when friend is loaded or change the order in the deps vector. Or bump friends dependencies.

@dgellow
Copy link
Author

dgellow commented Dec 8, 2014

The conflict can be visualized by diffing lein deps :tree

$ diff --side-by-side --suppress-common-lines first.txt second.txt
                                                  >   [org.apache.httpcomponents/httpclient "4.3.5" :exclusions 
 [com.cemerick/friend "0.2.0"]                    |   [com.cemerick/friend "0.2.0" :exclusions [[org.apache.httpco
   [org.apache.httpcomponents/httpclient "4.2.1"]  <

@ddellacosta
Copy link
Contributor

Hmm, I'm not sure about this exclusion though, because it looks like this revision is used in friend to resolve a particular issue. I wonder if it would be better to simply leave clj-http for now--I'll have to look into it a bit further.

@plexus
Copy link

plexus commented Dec 12, 2014

There is a corresponding issue here: plexus/chestnut#47 because leiningen and friend-oauth2 require incompatible versions of clj-http.

If bumping the version would be at all possible that would be great, the chance of causing incompatibilities with other libs using clj-http will only increase as time goes on.

@ddellacosta
Copy link
Contributor

Responded in plexus/chestnut#47 (comment)

@dgellow Thanks for this and sorry to make your work moot, but I've done a bit more thorough of a version bump and tested, seems okay. In any case appreciate you bringing it to my attention so your PR was not a waste!

(see release 1.3)

@dgellow
Copy link
Author

dgellow commented Dec 13, 2014

@ddellacosta No problem :) Thank you for your work by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants