Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode after record #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

picasocro1
Copy link

Added new config param: encodeAfterRecord (#13)
Updated sample to show this feature too

Maciej Kubiak added 2 commits August 9, 2020 00:18
Added pause recording functionality (closeio#17)
Updated sample to show this feature too
Added new config param: encodeAfterRecord (closeio#13)
Updated sample to show this feature too
@charlypoly
Copy link

@buzinas how can we help to have this merged and released?

(We do use this fix in production to have a good recording quality at all time and faced no regression with this build)

@neelrocketbots
Copy link

Any news on this yet? This is a really useful feature

@canove
Copy link

canove commented Mar 30, 2021

Waiting for this too

@rohanyupadhyay
Copy link

Any update on this? We're having same issue. This pull request is about an year old. At least respond to our comments.

@joseinaqa
Copy link

We are using this branch as a dependency for our production site, please don't remove the branch. 😁

@avalenti89
Copy link

I don't know why but I tried to use this branch on my react-app and it become worst on mobile.
If I use the current 2.2.2 with android/chrome on Samsung S20 ultra it works perfectly, but it does not on iphone 8 and older android phone.
If I use this branch version, it doesn't work on S20 ultra too.

Copy link

@CSFelix CSFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants