Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch image building workflow for Docker Hub #341

Conversation

jihoon-seo
Copy link
Member

CC: @hermitkim1

[발동 조건]

on:
  pull_request:
    branches: master # master branch 에 대한 PR 이 올라왔을 때
  push:
    branches: master # master branch 에 push 가 발생했을 때
    tags:
      - "v*.*.*" # 새로운 tag 가 찍혔을 때

[동작]

docker buildx 로 multi-arch build 하고 (Raspberry Pi, Apple M1 등을 위한 arch 추가)
Docker Hub 으로 push 합니다.
(추후, GHCR 에도 push 하도록 설정할 수도 있습니다.)

[결과]

@jihoon-seo jihoon-seo force-pushed the 210105-Add-workflow-for-DockerHub branch from b817d69 to 987a480 Compare January 6, 2021 00:41
@seokho-son
Copy link
Member

Looks nice !! Is this PR working on progress ?

@jihoon-seo jihoon-seo changed the title Add workflow for Docker Hub Add multi-arch image building workflow for Docker Hub Jan 6, 2021
@jihoon-seo
Copy link
Member Author

@seokho-son
제 forked repo 에서 테스트 할 때에는
platforms: linux/amd64,linux/arm/v7,linux/arm64 로 했다가

cloud-barista/cb-tumblebug repo 에 PR 쓰면서 linux/arm/v6 도 추가했는데
linux/arm/v6 는 빌드가 되지 않는 문제가 있어서
해당 부분을 삭제하고 force-push 하니
모든 check 들을 통과했습니다.

지금은 완료되어 review-ready 입니다!

@seokho-son
Copy link
Member

LGTM, 감사합니다 ~ !

@seokho-son seokho-son merged commit 0c21eb4 into cloud-barista:master Jan 6, 2021
@jihoon-seo jihoon-seo deleted the 210105-Add-workflow-for-DockerHub branch January 6, 2021 01:16
@jihoon-seo
Copy link
Member Author

이 PR로 인해
"GitHub infra 에서 multi-arch build 하여 Docker Hub 으로 push" 하므로

기존에 Docker Hub 에 설정되어 있던
"Docker Hub infra 에서 amd64 build 하여 Docker Hub 에 등록" 하는 rule 은 disable 했습니다.

https://hub.docker.com/repository/docker/cloudbaristaorg/cb-tumblebug/builds/edit

image

@seokho-son
Copy link
Member

@jihoon-seo 넵 확인했습니다! 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants