Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c7n_tencentcloud - resources - cos #8044

Merged
merged 13 commits into from
Dec 10, 2022

Conversation

AndyChenGitHub
Copy link
Contributor

modify cos sdk version

…eature/tencentcloud_cos

# Conflicts:
#	tools/c7n_tencentcloud/c7n_tencentcloud/resources/resource_map.py
#	tools/c7n_tencentcloud/poetry.lock
#	tools/c7n_tencentcloud/requirements.txt
#	tools/c7n_tencentcloud/setup.py
tools/c7n_tencentcloud/c7n_tencentcloud/resources/cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/c7n_tencentcloud/resources/cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/tests/test_tc_cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/tests/test_tc_cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/tests/test_tc_cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/tests/test_tc_cos.py Outdated Show resolved Hide resolved
tools/c7n_tencentcloud/tests/test_tc_cos.py Outdated Show resolved Hide resolved
Copy link
Member

@thisisshi thisisshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@thisisshi
Copy link
Member

fyi please test your prs using assume role as well, in this case the assume role didn't work as the token was not being passed into the cos client

@thisisshi thisisshi merged commit 4de0f1a into cloud-custodian:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants