Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws - secrets manager delete and remove-statements action #8152

Merged
merged 11 commits into from
Jan 18, 2023
Merged

aws - secrets manager delete and remove-statements action #8152

merged 11 commits into from
Jan 18, 2023

Conversation

PratMis
Copy link
Collaborator

@PratMis PratMis commented Jan 12, 2023 •
edited
Loading

Closes #8100 #7647

@PratMis PratMis requested a review from kapilt as a code owner January 12, 2023 19:10
@PratMis PratMis changed the title Secrets manager delete action aws - secrets manager delete action Jan 12, 2023
@PratMis
Copy link
Collaborator Author

PratMis commented Jan 12, 2023 •
edited
Loading

I can go ahead and add the action to remove-statements to this PR, as per the requirement in #7647

@PratMis
Copy link
Collaborator Author

PratMis commented Jan 13, 2023 •
edited
Loading

I can go ahead and add the action to remove-statements to this PR, as per the requirement in #7647

Added, should be ready for review. Thanks

@PratMis PratMis changed the title aws - secrets manager delete action aws - secrets manager delete and remove-statements action Jan 13, 2023
thisisshi
thisisshi requested changes Jan 13, 2023
View reviewed changes
c7n/resources/secretsmanager.py Outdated Show resolved Hide resolved
thisisshi
thisisshi approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@thisisshi thisisshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can you change the docstring for the delete action to be accurate?

@thisisshi thisisshi merged commit a0e0557 into cloud-custodian:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisshi thisisshi thisisshi approved these changes

@kapilt kapilt Awaiting requested review from kapilt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secrets Manager - Add delete Secret action
2 participants
@PratMis @thisisshi