Fix naming conflict between validate argument and imported function #8265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validate
argument ofc7n.policy.load()
conflicts with the import statement on line 37 importingc7n.schema.validate()
. Subsequent if expressions that appear to test the argument are actually testing that the callablec7n.schema.validate()
function exists. This prevents anything callingload()
withvalidate=False
from preventing validation as expected.The fix here is to import as to rename the callable rather than rename the argument which might break other things calling the
load()
function.This will only change the behavior of anything calling
load()
withvalidate=False
so that validation does not occur as intended.