Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: prepare release 1.2.0 #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

releng: prepare release 1.2.0 #28

wants to merge 1 commit into from

Conversation

ajkerrigan
Copy link
Member

The main motivation here is shipping support for Poetry v2 (while continuing to work with 1.x).

@ajkerrigan ajkerrigan mentioned this pull request Jan 10, 2025
Closed
DBS-ST-VIT
DBS-ST-VIT reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@DBS-ST-VIT DBS-ST-VIT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

Just one hint: In the pyproject.toml, a Apache-2.0 license is mentioned, but the repository currently doesnt have a LICENSE file. This is actually no problem for the release, just a general hint.

@DBS-ST-VIT DBS-ST-VIT mentioned this pull request Jan 13, 2025
Merged
@DBS-ST-VIT
Copy link
Contributor

DBS-ST-VIT commented Jan 13, 2025 •
edited
Loading

Just one hint: In the pyproject.toml, a Apache-2.0 license is mentioned, but the repository currently doesnt have a LICENSE file. This is actually no problem for the release, just a general hint.

I just created #29 - guess thats no big thing at all.

Is there any plan, when 1.2.0 will be released? Just for our planning, as our poetry v2 migration story depends on this PR.

@ajkerrigan
Copy link
Member Author

I'd like to get it out next week, ideally getting this and #30 approved/landed so we can publish a release with your recent fixes and the multiple-package-version issue sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DBS-ST-VIT DBS-ST-VIT DBS-ST-VIT left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajkerrigan @DBS-ST-VIT